Skip to content

[WIP] Actually write Variant to files with default strategy.#7945

Draft
AdamGS wants to merge 6 commits into
developfrom
adamg/variant-to-file
Draft

[WIP] Actually write Variant to files with default strategy.#7945
AdamGS wants to merge 6 commits into
developfrom
adamg/variant-to-file

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented May 15, 2026

Summary

pretty important piece that's still missing.

Comment thread vortex-file/src/strategy.rs Outdated

if use_experimental_patches() {
allowed.insert(Patched.id());
allowed.insert(ParquetVariant.id());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be here

@AdamGS AdamGS force-pushed the adamg/variant-to-file branch from f346137 to f890749 Compare May 15, 2026 14:51
AdamGS added 4 commits May 15, 2026 16:48
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/variant-to-file branch from f890749 to 040589f Compare May 15, 2026 15:48
Signed-off-by: Adam Gutglick <[email protected]>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 12.43%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 1216 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 2)] 148.5 µs 169.6 µs -12.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/variant-to-file (be751dc) with develop (96dda71)

Open in CodSpeed

Signed-off-by: Adam Gutglick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants