[WIP] Actually write Variant to files with default strategy.#7945
Draft
AdamGS wants to merge 6 commits into
Draft
[WIP] Actually write Variant to files with default strategy.#7945AdamGS wants to merge 6 commits into
AdamGS wants to merge 6 commits into
Conversation
25733a8 to
589413b
Compare
robert3005
reviewed
May 15, 2026
|
|
||
| if use_experimental_patches() { | ||
| allowed.insert(Patched.id()); | ||
| allowed.insert(ParquetVariant.id()); |
f346137 to
f890749
Compare
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
Signed-off-by: Adam Gutglick <[email protected]>
f890749 to
040589f
Compare
Signed-off-by: Adam Gutglick <[email protected]>
Merging this PR will degrade performance by 12.43%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | encode_varbin[(1000, 2)] |
148.5 µs | 169.6 µs | -12.43% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/variant-to-file (be751dc) with develop (96dda71)
Signed-off-by: Adam Gutglick <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pretty important piece that's still missing.