Skip to content

skip[ci]: fmt fix in ci#7943

Open
joseph-isaacs wants to merge 11 commits into
developfrom
ji/fmt-fix
Open

skip[ci]: fmt fix in ci#7943
joseph-isaacs wants to merge 11 commits into
developfrom
ji/fmt-fix

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs commented May 15, 2026

Try to auto-fix fmt errors using a github-bot

u
Signed-off-by: Joe Isaacs <[email protected]>
u
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs changed the title u skip[ci]: fmt fix in ci May 15, 2026
u
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review May 15, 2026 11:44
u
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label May 15, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 12.27%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 1216 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 2)] 148.5 µs 169.2 µs -12.27%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/fmt-fix (01f2033) with develop (96dda71)

Open in CodSpeed

u
Signed-off-by: Joe Isaacs <[email protected]>
u
Signed-off-by: Joe Isaacs <[email protected]>
u
Signed-off-by: Joe Isaacs <[email protected]>
github-actions Bot and others added 2 commits May 15, 2026 15:13
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joseph-isaacs
Copy link
Copy Markdown
Contributor Author

@claude review this can we do this in a better way security and code org wise?

@github-actions
Copy link
Copy Markdown
Contributor

Claude review automation is disabled for pull requests that modify .github/ files.

Why:

  • workflow and action files are part of the automation policy
  • this review workflow refuses to evaluate automation changes from the same PR

Ask a human reviewer to inspect workflow changes directly.

@gatesn gatesn added the tldr label May 15, 2026
u
Signed-off-by: Joe Isaacs <[email protected]>
u
Signed-off-by: Joe Isaacs <[email protected]>
@tl-dr-review tl-dr-review Bot added tldr and removed tldr labels May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog tldr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants