Skip to content

🥸#7932

Closed
a10y wants to merge 1 commit into
developfrom
aduffy/arrow-vtable-indisguise
Closed

🥸#7932
a10y wants to merge 1 commit into
developfrom
aduffy/arrow-vtable-indisguise

Conversation

@a10y
Copy link
Copy Markdown
Contributor

@a10y a10y commented May 14, 2026

Summary

Closes: #000

Testing

Signed-off-by: Andrew Duffy <[email protected]>

more of the owl

Signed-off-by: Andrew Duffy <[email protected]>

fix sillyness

Signed-off-by: Andrew Duffy <[email protected]>

lockfiles, more stuff

Signed-off-by: Andrew Duffy <[email protected]>

save

Signed-off-by: Andrew Duffy <[email protected]>

fixup + wire into DF

Signed-off-by: Andrew Duffy <[email protected]>

fixup

Signed-off-by: Andrew Duffy <[email protected]>

chain dtype plugin calls

Signed-off-by: Andrew Duffy <[email protected]>

polyfill has_valid_extension_type method for 0.58.0

Signed-off-by: Andrew Duffy <[email protected]>

ok, use something that actually works 58.0.0

Signed-off-by: Andrew Duffy <[email protected]>

use Arc instead of Vec in session

Signed-off-by: Andrew Duffy <[email protected]>

deprecate + move away from deprecated

Signed-off-by: Andrew Duffy <[email protected]>

Wire Vector into Arrow conversion (#7880)

Register `Vector` as an Arrow import/export plugin on the new
`ArrowSession`, so a Vortex Vector extension array can go to Arrow and
back without losing its identity.

Note: If the plugin is not registered, imports fall back to the plain
FSL (no error, but the Vector identity is dropped).

---------

Signed-off-by: Baris Palaska <[email protected]>

wire in ArrowSession

Signed-off-by: Andrew Duffy <[email protected]>

fixup

Signed-off-by: Andrew Duffy <[email protected]>

fix dtype dispatch

Signed-off-by: Andrew Duffy <[email protected]>

avoid cloning

Signed-off-by: Andrew Duffy <[email protected]>

save

Signed-off-by: Andrew Duffy <[email protected]>

remove empty files

Signed-off-by: Andrew Duffy <[email protected]>

fixup

Signed-off-by: Andrew Duffy <[email protected]>

add microbenchmark

Signed-off-by: Andrew Duffy <[email protected]>

taplo fmt

Signed-off-by: Andrew Duffy <[email protected]>

remove unused method

Signed-off-by: Andrew Duffy <[email protected]>

silly lints

Signed-off-by: Andrew Duffy <[email protected]>
@a10y a10y force-pushed the aduffy/arrow-vtable-indisguise branch from f7ea15d to c9c4ae6 Compare May 14, 2026 21:15
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will degrade performance by 10.24%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 1 regressed benchmark
✅ 692 untouched benchmarks
⏩ 523 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation canonicalize_compare[(1000, 4, 4)] 122.7 µs 136.7 µs -10.24%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing aduffy/arrow-vtable-indisguise (c9c4ae6) with develop (8c5a0f1)

Open in CodSpeed

Footnotes

  1. 523 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@a10y a10y closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant