ci: fix code path filter negation

[nicktrn]

dorny/paths-filter defaults to OR semantics across the pattern array, so the leading ** matched every file and the !... excludes were no-ops. The code filter has been returning true for every PR since #3615.

Split into two filter steps: code moves into its own step with predicate-quantifier: every so excludes actually subtract. The two re-include workflow files become a separate typecheck_self filter that the typecheck job ORs into its if:.

Side effect: workflow-file-only PRs that don't touch pr_checks.yml or typecheck.yml no longer trigger typecheck. Previously they did because the filter was broken-true.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8507d73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ba7ec11c-fbb7-47a7-81b5-966d83675159

📥 Commits

Reviewing files that changed from the base of the PR and between 05d3ab1 and 8507d73.

📒 Files selected for processing (1)

• .github/workflows/pr_checks.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)

• GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 8)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (2, 8)
• GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (1, 8)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (4, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (7, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (8, 8)
• GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 8)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (3, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (6, 8)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 8)
• GitHub Check: internal / 🧪 Unit Tests: Internal (5, 8)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 8)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: sdk-compat / Deno Runtime
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: sdk-compat / Cloudflare Workers
• GitHub Check: sdk-compat / Bun Runtime
• GitHub Check: typecheck / typecheck
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
• GitHub Check: packages / 🧪 Unit Tests: Packages (1, 1)
• GitHub Check: audit
• GitHub Check: audit
• GitHub Check: Analyze (actions)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

.github/workflows/pr_checks.yml (1)

20-21: LGTM!

Also applies to: 28-35, 45-50, 108-108

---

Walkthrough

The PR updates the .github/workflows/pr_checks.yml workflow to refine its path-filter detection strategy. The changes job now introduces a distinct code_filter step using dorny/paths-filter with predicate-quantifier: every. A new typecheck_self filter entry is added to the filter configuration. The typecheck job's execution condition is expanded to run when either changes.outputs.code or changes.outputs.typecheck_self is true, instead of only checking code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides a thorough technical explanation of the problem and solution, but does not follow the required template structure with sections like Checklist, Testing, Changelog, and Screenshots.	Add the required template sections including a Checklist, Testing steps, Changelog entry, and confirm all fields are properly completed per the template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: fixing a code path filter negation issue in CI workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/pr-checks-filter-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.