feat: add importOverrides as a variant of componentImports#578
Open
rpd10 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add an
importOverridesoption toRenderComponentOptionsthat allows authors to replace specific component imports without replacing the entire imports array. This complements the existingcomponentImports(full replacement) option.Motivation
Test authors may want to mock 1-2 heavy child components without enumerating all imports. Today, there are 2 ways to accomplish this:
componentImportsrequires listing every import (full replacement via{ set: { imports } }). This is fine for components with few imports, but if you have many, it can be cumbersome and unintuitive.configureTestBedwith rawTestBed.overrideComponent— leaks Angular internals into test code:Enhancement
This PR adds some sugar on top of the overrideComponent option to make it easier to override a subset of the component imports: