Include keypoints_metadata.json when uploading model#478
Open
grzegorz-roboflow wants to merge 2 commits into
Open
Include keypoints_metadata.json when uploading model#478grzegorz-roboflow wants to merge 2 commits into
grzegorz-roboflow wants to merge 2 commits into
Conversation
tonylampada
approved these changes
May 14, 2026
Collaborator
tonylampada
left a comment
There was a problem hiding this comment.
LGTM
there's improvement suggestion from 🤖 review that might be worth looking into:
a user deploying a pose model from a directory that lacks keypoints_metadata.json gets a successful upload acknowledgment but a broken deployed model — with no feedback about what went wrong.
This is a "should fix before merge" concern, not a blocker, because the PR already improves the status quo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Include keypoints_metadata.json when uploading model, so users can upload keypoint models
Type of Change
Testing
Tested locally
Checklist
Additional Context
N/A