Skip to content

Revert "feat: add Filipino (fil_PH) locale support (#967)"#968

Merged
afc163 merged 1 commit into
react-component:masterfrom
jinrong-ncu:revert-967-master
May 14, 2026
Merged

Revert "feat: add Filipino (fil_PH) locale support (#967)"#968
afc163 merged 1 commit into
react-component:masterfrom
jinrong-ncu:revert-967-master

Conversation

@jinrong-ncu
Copy link
Copy Markdown
Contributor

This reverts commit f3cc765.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

@jinrong-ncu is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@jinrong-ncu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 13 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba7cd948-ffc6-4206-a4de-2dc288ba7112

📥 Commits

Reviewing files that changed from the base of the PR and between f3cc765 and a70b72b.

📒 Files selected for processing (1)
  • src/locale/fil_PH.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Filipino locale configuration file. Feedback indicates that this change is incomplete because deleting the file without updating the corresponding imports and exports in the main locale entry point will likely result in compilation errors.

I am having trouble creating individual review comments. Click here to see my feedback.

src/locale/fil_PH.ts (1-32)

high

The revert of the Filipino locale appears to be incomplete. Deleting the locale file without removing its corresponding import and export in the locale entry point (typically src/locale/index.ts) will cause a compilation error because the module will no longer be found. All references to the fil_PH locale should be removed across the repository to complete the revert.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (f3cc765) to head (a70b72b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          65       65           
  Lines        2695     2695           
  Branches      724      724           
=======================================
  Hits         2663     2663           
  Misses         29       29           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jinrong-ncu
Copy link
Copy Markdown
Contributor Author

Add Filipino (Tagalog) translation for picker components. Use tl_PH instead of fil_PH to align with the ecosystem standards, ensuring compatibility with dayjs (tl-ph) and antd integration.

@afc163 afc163 merged commit 843422d into react-component:master May 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants