gh-141968: Use take_bytes to simplify and remove copy from pyrepl BaseEventQueue#149852
Open
lgeiger wants to merge 4 commits into
Open
gh-141968: Use take_bytes to simplify and remove copy from pyrepl BaseEventQueue#149852lgeiger wants to merge 4 commits into
take_bytes to simplify and remove copy from pyrepl BaseEventQueue#149852lgeiger wants to merge 4 commits into
Conversation
…repl `BaseEventQueue`
6 tasks
Contributor
|
cc @cmaloney |
maurycy
reviewed
May 15, 2026
| return not self.events | ||
|
|
||
| def flush_buf(self) -> bytearray: | ||
| def flush_buf(self) -> bytes: |
Contributor
There was a problem hiding this comment.
Maybe this method is redundant now?
Contributor
Author
There was a problem hiding this comment.
I'm happy to remove the function. For now I kept it to keep the diff small. But happy to remove it and just use self.buf.take_bytes() instead. Let me know what you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
bytearray.take_bytesto simplify pyrepl'sBaseEventQueue.flush_bufand remove copies fromBaseEventQueue.push