Skip to content

test: fix compiler warnings in test_node_crypto.cc#63341

Open
mpatankar6 wants to merge 1 commit into
nodejs:mainfrom
mpatankar6:test-node-crypto-warnings
Open

test: fix compiler warnings in test_node_crypto.cc#63341
mpatankar6 wants to merge 1 commit into
nodejs:mainfrom
mpatankar6:test-node-crypto-warnings

Conversation

@mpatankar6
Copy link
Copy Markdown

@mpatankar6 mpatankar6 commented May 15, 2026

test: fix compiler warnings in test_node_crypto.cc

Fixes the warnings by using the correct literal type. Also removed some
assertions which were just identity tests for constexprs. The bounds
checks are sufficient to verify the constants are nonzero and reasonable,
and will survive OpenSSL changes without needing to be updated.

Fixes: #63325

Signed-off-by: Mihir Patankar [email protected]

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (ee11c35) to head (f48223e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63341      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files         714      714              
  Lines      225490   225490              
  Branches    42633    42635       +2     
==========================================
- Hits       203072   203069       -3     
  Misses      14193    14193              
- Partials     8225     8228       +3     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler warnings in test_node_crypto.cc

2 participants