stream: add sync iterable fast path to pipeTo#63318
Open
trivikr wants to merge 2 commits into
Open
Conversation
Avoid normalizing sync iterable sources through from() when pipeTo() has no transforms or signal and the writer can accept sync writes. This keeps writes incremental while preserving async fallback for values that still need it. Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63318 +/- ##
==========================================
+ Coverage 90.04% 90.07% +0.02%
==========================================
Files 714 714
Lines 225338 225388 +50
Branches 42598 42628 +30
==========================================
+ Hits 202897 203009 +112
+ Misses 14236 14155 -81
- Partials 8205 8224 +19
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a
pipeTo()fast path for synchronous iterable sources when thereare no transforms, no abort signal, and the writer supports
writeSync().Previously,
pipeTo()always normalized throughfrom(), which routes synciterables through the async normalization path. The new guarded path writes
incrementally from the sync iterator while preserving async fallback behavior
for values that still require async normalization.
Benchmark
Assisted-by: openai:gpt-5.5