Skip to content

test: unskip snapshot reproducibility test#63307

Open
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:unskip-test
Open

test: unskip snapshot reproducibility test#63307
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:unskip-test

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

See if the v8 14.6 upgrade has fixed it.

On a side note, debian will require reproducible builds in their packages https://lists.debian.org/debian-devel-announce/2026/05/msg00001.html

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2026
@joyeecheung
Copy link
Copy Markdown
Member Author

cc @panva @sxa

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (78bbee3) to head (84a53dc).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63307      +/-   ##
==========================================
+ Coverage   90.04%   90.05%   +0.01%     
==========================================
  Files         713      714       +1     
  Lines      225003   225247     +244     
  Branches    42536    42584      +48     
==========================================
+ Hits       202606   202852     +246     
- Misses      14177    14179       +2     
+ Partials     8220     8216       -4     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 15, 2026

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels May 15, 2026
Copy link
Copy Markdown
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reproducibility test job hasn't been showing any problems, although it's still configured to build with gcc. Have you been seeing problems pre-14.6?
Either way I'm happy to have this test unskipped :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants