tools: bump temporal_rs version#63281
Open
aduh95 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Antoine du Hamel <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
aduh95
added
dont-land-on-v22.x
Collaborator
Member
|
I think the rustc version needs to be bumped on the CI. |
Renegade334
reviewed
May 14, 2026
Comment on lines
28
to
29
| # This is necessary to enable a spec-compliance quirk when upgrading to v0.1.2 | ||
| # features = ["float64_representable_durations"] |
Member
There was a problem hiding this comment.
Suggested change
| # This is necessary to enable a spec-compliance quirk when upgrading to v0.1.2 | |
| # features = ["float64_representable_durations"] | |
| # This is necessary to enable a spec-compliance quirk | |
| features = ["float64_representable_durations"] |
Member
|
👍 to bringing these into line with the V8 14.6 deps in the first instance. If it's feasible to bring rustc 1.86 to the build runners, then it would be useful to look at upgrading these dependencies to 0.2.x before v26.x goes LTS, to fix a whole host of spec divergences – otherwise we are going to force LTS consumers to wait until October 2027 for a working-as-expected Temporal implementation. (The C++ API is the same, so it's a case of plug and play as far as the vendored crates goes – have a test build without any hassle.) |
Contributor
Author
|
Blocked on nodejs/build#4265 or similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #63145 (comment)