ci: update egress policies, apply zizmor recommendations#792
Conversation
PR SummaryMedium Risk Overview Reduces credential and trigger exposure by setting Adds a new Reviewed by Cursor Bugbot for commit 7de39fe. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 159 159
Lines 14056 14056
Branches 1152 1152
=======================================
Hits 10957 10957
Misses 3094 3094
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ed3ba1b to
8a05720
Compare
Signed-off-by: flakey5 <[email protected]>
ad452f9 to
7de39fe
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7de39fe. Configure here.
| if: needs.prepare.outputs.should_publish == 'true' | ||
| permissions: | ||
| # For npm OIDC (https://docs.npmjs.com/trusted-publishers) | ||
| id-token: write |
There was a problem hiding this comment.
Publish job loses contents: read from permission override
High Severity
The publish job defines job-level permissions with only id-token: write. In GitHub Actions, job-level permissions completely replace (not merge with) workflow-level permissions. This means the publish job loses the workflow-level contents: read permission. Without contents: read, the nodejs/web-team/actions/setup-environment action won't be able to check out the repository, and npm publish will have no package to publish. The contents: read permission needs to be included alongside id-token: write in the job-level permissions block.
Reviewed by Cursor Bugbot for commit 7de39fe. Configure here.


Description
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.