CmdPal: Extension Gallery - Allow only HTTP/HTTPS URIs as links in the UI#47898
Open
jiripolasek wants to merge 1 commit into
Open
CmdPal: Extension Gallery - Allow only HTTP/HTTPS URIs as links in the UI#47898jiripolasek wants to merge 1 commit into
jiripolasek wants to merge 1 commit into
Conversation
…thor page and the homepage
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens CmdPal extension gallery link handling by filtering gallery and WinGet metadata links so only HTTP/HTTPS URIs are exposed as clickable UI links.
Changes:
- Adds cached web-only URI fields for homepage, author page, and install link commands.
- Filters source and metadata detail links through HTTP/HTTPS validation.
- Adds unit tests covering non-web gallery links and WinGet metadata links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Gallery/ExtensionGalleryItemViewModel.cs |
Restricts gallery links and source detail links to HTTP/HTTPS before exposing commands or hyperlink URIs. |
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/ExtensionGalleryItemViewModelTests.cs |
Adds tests verifying non-web gallery and WinGet metadata links are ignored while safe web links remain available. |
zadjii-msft
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR filters URIs from extension gallery and allows only HTTP/HTTPS URIs as links for the installation page.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed