Skip to content

CmdPal: Extension Gallery - Allow only HTTP/HTTPS URIs as links in the UI#47898

Open
jiripolasek wants to merge 1 commit into
mainfrom
feature/extension-gallery-use-http-schemes-only
Open

CmdPal: Extension Gallery - Allow only HTTP/HTTPS URIs as links in the UI#47898
jiripolasek wants to merge 1 commit into
mainfrom
feature/extension-gallery-use-http-schemes-only

Conversation

@jiripolasek
Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This PR filters URIs from extension gallery and allows only HTTP/HTTPS URIs as links for the installation page.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jiripolasek jiripolasek added the Product-Command Palette Refers to the Command Palette utility label May 15, 2026
@jiripolasek jiripolasek mentioned this pull request May 15, 2026
10 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens CmdPal extension gallery link handling by filtering gallery and WinGet metadata links so only HTTP/HTTPS URIs are exposed as clickable UI links.

Changes:

  • Adds cached web-only URI fields for homepage, author page, and install link commands.
  • Filters source and metadata detail links through HTTP/HTTPS validation.
  • Adds unit tests covering non-web gallery links and WinGet metadata links.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Gallery/ExtensionGalleryItemViewModel.cs Restricts gallery links and source detail links to HTTP/HTTPS before exposing commands or hyperlink URIs.
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/ExtensionGalleryItemViewModelTests.cs Adds tests verifying non-web gallery and WinGet metadata links are ignored while safe web links remain available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.100 Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants