Document help_center default and locales fields in Preview spec#494
Open
ib-skoric wants to merge 1 commit into
Open
Conversation
Add two new fields to the help_center schema in the Preview OpenAPI spec, matching intercom/intercom#508490: - default (boolean): whether the help center is the workspace default - locales (array of strings): locale codes the help center supports Also update the inline response example for GET /help_center/help_centers/{id} to include the new fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
PR intercom/intercom#508490 added
defaultandlocalesfields to the Help Center API response on the Preview version, but the OpenAPI spec did not document them. Without this update, SDK consumers on Preview would miss the fields in generated types and the API docs would be inaccurate.How?
Added
default(boolean) andlocales(array of strings) properties to thehelp_centerschema in the Preview spec and updated the inline response example for the single help center GET endpoint.Decisions
descriptions/0/api.intercom.io.yamlsince the fields are Preview-version onlygenerate-openapi-from-prbecause the change is small and precisely scopeddefaultafter the existingwebsite_turned_onboolean property andlocalesas an array of string locale codes, matching test data (["en", "fr"])dataarray, so no example change was needed thereReview Guidance
░░░░░░░░░░ 0.4Why
Two property additions to a single schema plus one example update — no cross-cutting impact.░░░░░░░░░░ 0.3Why
Diff matches the PR description and plan verbatim with no hidden behavior.░░░░░░░░░░ 0.5Why
Documentation-only YAML change in the Preview spec; no runtime or sensitive paths touched.Attention: Routine review — Tiny, precisely-scoped OpenAPI doc addition matching the plan exactly; nothing non-obvious to flag.
🧪 This AI-generated review guidance is experimental. Share feedback
Implementation Plan
Worker Implementation Plan
Plan: Add
defaultandlocalesfields to Help Center schema (Preview)Context
PR intercom/intercom#508490 added two new fields to the Help Center API response, gated behind the Preview/Unstable API version:
default(boolean) — whether the help center is the workspace's default (model.is_default)locales(array of string locale codes) — the help center's selected languages (model.selected_locale_ids), e.g.["en", "fr"]The version change class
AddDefaultAndLocalesToHelpCenterResponsestrips these fields for stable API clients. Only the Preview spec (descriptions/0/api.intercom.io.yaml) needs updating.Changes Required
1. Add properties to
help_centerschema (line ~26439)File:
descriptions/0/api.intercom.io.yamlLocation: After the
custom_domainproperty (ends at line 26439), before thehelp_center_listschema (line 26440).Add two new properties:
Conventions followed:
website_turned_on(line 26422) —type: boolean,description,exampletype: arraywithitems: type: stringand inlineexamplelist["en", "fr"])2. Update inline response example for GET /help_center/help_centers/{id} (line ~2782)
File:
descriptions/0/api.intercom.io.yamlLocation: After
custom_domain: help.mycompany.com(line 2782) in the "Collection found" example.Add:
3. No change needed for GET /help_center/help_centers (list endpoint)
The list endpoint example at line 2832-2834 shows
data: [](empty array). No individual help center example to update.4. No other endpoints reference the
help_centerschemaConfirmed: only two
$refreferences tohelp_center— the GET single endpoint (line 2784) andhelp_center_list.items(line 26457).Verification
fern checkto validate the spec:help_centerschemaImplementation Notes
generate-openapi-from-prskill — the changes are small and precisely scoped; manual edits are faster and more controlled.properties:, 10 spaces for sub-keys).nullablefor required fields, string examples unquoted when simple identifiers.Parthas Order (task/issue)
Add Help Center default and locales fields to OpenAPI spec
Problem
PR intercom/intercom#508490 added
default(boolean) andlocales(array of locale IDs) fields to the Help Center API response, gated behind the Preview API version viaAddDefaultAndLocalesToHelpCenterResponse. The intercom-openapi spec does not yet document these fields — thehelp_centerschema indescriptions/0/api.intercom.io.yamlis missing them.Why This Matters
Without the spec update, SDK consumers on the Preview version will not see these fields in generated types, and the API documentation will be inaccurate.
Goal
The Preview OpenAPI spec documents the
defaultandlocalesfields on thehelp_centerschema, with correct types, descriptions, and examples.Context
descriptions/0/api.intercom.io.yamlneeds updatinggenerate-openapi-from-prskill — use it with the source PR URLhelp_centerschema is at approximately line 26391 of the preview specAcceptance Criteria
help_centerschema indescriptions/0/api.intercom.io.yamlincludesdefault(boolean) andlocales(array) propertiesfern checkpassesGenerated with Claude Code, zen coded with Parthas