fix(scripts): new-worktree --compiler guard, yarn cleanup trap, and gitignore comment#36476
fix(scripts): new-worktree --compiler guard, yarn cleanup trap, and gitignore comment#36476iamdaven wants to merge 1 commit into
Conversation
…itignore check - Error immediately if --compiler is passed without --claude instead of silently ignoring it - Run yarn installs in the current shell instead of subshells so the ERR trap reliably fires and cleans up the worktree on failure - Add comment documenting all valid .gitignore forms for .worktrees so the regex isn't incorrectly "fixed" by a future contributor
|
Hi @iamdaven! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
--compiler without --claude now errors immediately. Previously the flag was silently ignored, which was confusing since it has no effect on its own.
yarn install failures now correctly trigger cleanup. Both installs were running in subshells ((cd ... && yarn)), which causes trap ERR to behave inconsistently across bash versions — the worktree could be left behind on a failed install. Replaced with direct cd && yarn in the current shell so the trap reliably fires.
Added a comment documenting valid .gitignore forms for .worktrees. The regex accepts /.worktrees, .worktrees/, and /.worktrees/ in addition to .worktrees, but nothing made that clear. A future contributor would likely "fix" it incorrectly without the comment.