Allow the external CAs to be removed entirely using the CL (carry 1179)#6979
Draft
thaJeztah wants to merge 1 commit into
Draft
Allow the external CAs to be removed entirely using the CL (carry 1179)#6979thaJeztah wants to merge 1 commit into
thaJeztah wants to merge 1 commit into
Conversation
Allow setting --external-ca to an empty string, to allow for removing all external CAs entirely. This will help for instance if rotating from a fully external CA to an internal CA (if the CA's cert and key are already in the swarm for instance). Signed-off-by: Ying Li <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting --external-ca to an empty string, to allow for removing all external CAs entirely. This will help for instance if rotating from a fully external CA to an internal CA (if the CA's cert and key are already in the swarm for instance).
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)