Skip to content

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#38504

Open
Amar3tto wants to merge 1 commit into
apache:release-2.74from
Amar3tto:postcommit_validation_pr
Open

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#38504
Amar3tto wants to merge 1 commit into
apache:release-2.74from
Amar3tto:postcommit_validation_pr

Conversation

@Amar3tto
Copy link
Copy Markdown
Collaborator

Tests run on GHA should be queued shortly.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration file designed to trigger automated testing workflows on the release branch via GitHub Actions. The purpose of this change is to ensure system stability and verify code integrity by running the full suite of pre- and post-commit tests.

Highlights

  • Automated Test Triggering: Added a new configuration file to initiate PostCommit and PreCommit tests on the release branch.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the build label May 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new file, release/trigger_all_tests.json, containing an empty JSON object. The reviewer suggests adding a descriptive field to the JSON for better maintainability and ensuring the file includes a trailing newline for POSIX compatibility.

@@ -0,0 +1 @@
{}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the maintainability and clarity of this trigger file, consider adding a descriptive field such as a reason or a timestamp. This documents the intent for future maintainers and provides a standard way to modify the file for subsequent test triggers. Additionally, ensure the file ends with a trailing newline to adhere to standard POSIX and tool compatibility practices.

Suggested change
{}
{
"reason": "Manual trigger for PostCommit and PreCommit tests on release branch"
}

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

12 files   -  25  12 suites   - 25   1h 31m 18s ⏱️ - 6m 47s
15 tests  - 171  15 ✅  - 169  0 💤  -  2  0 ❌ ±0 
15 runs   - 703  15 ✅  - 683  0 💤  - 20  0 ❌ ±0 

Results for commit 7204a77. ± Comparison against base commit a1d3469.

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto
Copy link
Copy Markdown
Collaborator Author

There are expected Dataflow failures.
Also ULR and ML deps failures - cherrypicked fixes for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant