fix(aria/menu): defer menu item focus in case menus in cdk overlay#33258
Open
ok7sai wants to merge 1 commit into
Open
fix(aria/menu): defer menu item focus in case menus in cdk overlay#33258ok7sai wants to merge 1 commit into
ok7sai wants to merge 1 commit into
Conversation
ok7sai
force-pushed
the
fix/aria-menu-overlay
branch
from
c74e7af to
6a24e03
Compare
When menus are placed in a `CdkConnectedOverlay`, the menu trigger tries to focus the first menu item even before the menus are rendered and registered to the menu trigger.
ok7sai
force-pushed
the
fix/aria-menu-overlay
branch
from
6a24e03 to
7d0ba63
Compare
tjshiu
reviewed
May 15, 2026
Comment on lines
+52
to
+60
| originalOnClick(); | ||
| trigger.pendingFocusEffect(); | ||
| }; | ||
|
|
||
| const originalOnKeydown = trigger.onKeydown.bind(trigger); | ||
| trigger.onKeydown = (event: KeyboardEvent) => { | ||
| originalOnKeydown(event); | ||
| trigger.pendingFocusEffect(); | ||
| }; |
Contributor
There was a problem hiding this comment.
Does await fixture.whenStable() in the test cases help instead of calling this method?
Member
Author
There was a problem hiding this comment.
In the UI patterns pendingFocusEffect() doesn't get called automatically because it's exposed for directives to actually use them as effect(() => pattern.pendingFocusEffect()). In the UI pattern tests the function has to be called manually.
tjshiu
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When menus are placed in a
CdkConnectedOverlay, the menu trigger tries to focus the first menu item even before the menus are rendered and registered to the menu trigger.