fix(redact/vite): respect 'forwardRef' and 'classComponents' feature flags#15
Open
sukvvon wants to merge 1 commit into
Open
fix(redact/vite): respect 'forwardRef' and 'classComponents' feature flags#15sukvvon wants to merge 1 commit into
sukvvon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vite plugin's feature-flag swap was a silent no-op for two flags:
forwardRef: falseandclassComponents: false. Other flags(
portal,context,suspense,memo,lazy) worked because theirfolder names happen to match the
ResolvedFeatureskey 1:1.Root cause
features/index.tsimports each feature by its on-disk folder name:The
resolveIdhook receives the bare specifier (./forward-ref,./class) and used to cast it directly tokeyof ResolvedFeatures:ResolvedFeaturesuses camelCase (forwardRef,classComponents), so'forward-ref' in featuresand'class' in featuresare bothfalse— the swap branch never ran and the full feature implementation stayed
in the bundle even when the user opted out.
Fix
Introduce an explicit folder → key mapping. The
resolve()call stilluses the folder name (it's a disk path), but the feature lookup uses
the mapped camelCase key.
Test plan
tests/vite-plugin-feature-swap.test.ts— 5 regression casescovering both kebab-mapped flags, the five identity-mapped flags,
the "flag on → no swap" path, and the RSC environment skip
forward-refandclasscases fail,confirming the test catches the regression
pnpm --filter tests test— all greenpnpm test:types— clean