[Security] Prevent absolute path bypass in sanitizeRelativePath#7550
[Security] Prevent absolute path bypass in sanitizeRelativePath#7550gonzaloriestra wants to merge 2 commits into
Conversation
Enhance sanitizeRelativePath to strip leading slashes and Windows drive letters, ensuring paths are strictly relative. Add unit tests to verify cross-platform safety.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Enhance sanitizeRelativePath to strip leading slashes and Windows drive letters, ensuring paths are strictly relative and cross-platform safe. Improve warning messages to accurately describe the security risk. Add unit tests for various traversal and absolute path scenarios.
WHY are these changes introduced?
The
sanitizeRelativePathfunction is intended to ensure a path provided by a user (e.g., in a configuration file) is relative and does not escape the intended directory. Previously, it only checked for..segments but allowed absolute paths (starting with/or Windows drive letters likeC:\) to pass through. This could allow an attacker to overwrite sensitive system files if the path is used as a destination in a file operation.WHAT is this pull request doing?
sanitizeRelativePathto detect and strip leading forward slashes and Windows drive letters.packages/cli-kit/src/public/node/path.test.tsto verify the fix across different OS path styles.How to test your changes?
You can verify the behavior by calling the
sanitizeRelativePathfunction with various inputs in a Node environment or via unit tests.Duplicate check
gh pr list --repo Shopify/cli --state all --limit 200 --search 'label:"Jules" "Security" in:title' --json number,title,state,url,body,files[Security] Redact cookies in sanitized headers output(Different subsystem, unrelated to path sanitization).Checklist
PR created automatically by Jules for task 7639287056760175654 started by @gonzaloriestra