[Tests] Remove filesystem mocks in execute-bulk-operation.test.ts#7543
[Tests] Remove filesystem mocks in execute-bulk-operation.test.ts#7543gonzaloriestra wants to merge 1 commit into
Conversation
Replace global filesystem mocks with real filesystem operations within
temporary directories. This improves test reliability by verifying actual
file content on disk instead of merely asserting mock call counts.
- Removed `vi.mock('@shopify/cli-kit/node/fs')`
- Updated tests to use `inTemporaryDirectory`
- Replaced `toHaveBeenCalledWith` on `writeFile` with `readFile` content checks
- Fixed a test expectation by adding missing `version` parameter to `runBulkOperationMutation`
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Why
The test suite for
executeBulkOperationwas using global filesystem mocks, which are fragile and can lead to non-deterministic tests or hide actual bugs in filesystem interactions.What
vi.mock('@shopify/cli-kit/node/fs')frompackages/app/src/cli/services/bulk-operations/execute-bulk-operation.test.ts.inTemporaryDirectoryandjoinPath.toHaveBeenCalledWith) with actual state verification (readFileand content comparison).versionparameter torunBulkOperationMutationcall in one test to match service expectations and fix a failing assertion caused by removing the mock.PR created automatically by Jules for task 4480568056550116275 started by @gonzaloriestra